Skip to content

Enable proc-macro2's nightly feature, to benchmark rustc's proc_macro implementation. #277

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
eddyb opened this issue Aug 24, 2018 · 2 comments

Comments

@eddyb
Copy link
Member

eddyb commented Aug 24, 2018

As pointed out in rust-lang/rust#49219 (comment), we're likely not seeing much action involving the real proc_macro bundled with the compiler, because proc-macro2, by default, shims all the APIs, and interacts with the real proc_macro through Strings (which was the only stabilized API for a while).
Any perf changes, in the implementation of the extended proc_macro APIs, may go by unnoticed.

cc @Mark-Simulacrum @nnethercote

@nnethercote
Copy link
Contributor

This reminds me of #239.

@dtolnay
Copy link
Member

dtolnay commented Jan 30, 2019

Proc-macro2 now automatically wraps libproc_macro on sufficiently new compilers, so the benchmarks are already measuring proc_macro performance.

@dtolnay dtolnay closed this as completed Jan 30, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants