Skip to content

script-servo is broken again #354

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
nnethercote opened this issue Feb 27, 2019 · 3 comments
Closed

script-servo is broken again #354

nnethercote opened this issue Feb 27, 2019 · 3 comments

Comments

@nnethercote
Copy link
Contributor

Buried among the many warnings is this error:

error[E0599]: no method named `trace` found for type `&for<\'r> fn(&\'r dom::node::Node) -> u16` in the current scope
   --> components/script/dom/treewalker.rs:470:10
    |
470 | #[derive(JSTraceable)]
    |          ^^^^^^^^^^^
    |
    = note: JSTraceable is a function, perhaps you wish to call it
    = help: items from traits can only be used if the trait is implemented and in scope
    = note: the following trait defines an item `trace`, perhaps you need to implement it:
            candidate #1: `dom::bindings::trace::JSTraceable`
@SimonSapin
Copy link
Contributor

This sounds related to rust-lang/rust#56105. Did the breakage occur when rust-lang/rust#58592 landed?

The fix might be adding an impl, similar to servo/servo#18327.

@nnethercote
Copy link
Contributor Author

nnethercote commented Feb 27, 2019

I removed an impl like that in #289 just last week. The conversation on IRC said the universes change was backed out, so seems like this is fallout from all that.

@nnethercote
Copy link
Contributor Author

I pushed a fix for this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants