Skip to content

file_lines with a comment is broken #1159

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
nrc opened this issue Sep 16, 2016 · 4 comments · Fixed by #1817
Closed

file_lines with a comment is broken #1159

nrc opened this issue Sep 16, 2016 · 4 comments · Fixed by #1817
Labels
bug Panic, non-idempotency, invalid code, etc. p-high

Comments

@nrc
Copy link
Member

nrc commented Sep 16, 2016

I think this is because we lose the distinction between a statement and expression and file-lines only bails from statements, not expressions. Not exactly sure why, but we then get the wrong indents for comments. I couldn't find a fix for this, so I had to delete the comments from the file-lines tests.

cc @kamalmarhubi

@nrc nrc added the bug Panic, non-idempotency, invalid code, etc. label Sep 16, 2016
@nrc
Copy link
Member Author

nrc commented Sep 16, 2016

@kamalmarhubi
Copy link
Contributor

Urg. I completely dropped this, didn't I? The implementation of the feature was never done after the initial PR. I'll try to take a look this week.

@kamalmarhubi
Copy link
Contributor

Oh and what do you mean by "only bails from"?

@nrc
Copy link
Member Author

nrc commented Sep 18, 2016

bails == early return (without doing any formatting)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Panic, non-idempotency, invalid code, etc. p-high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants