Skip to content

Tracking issue: skip attributes #1978

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
6 tasks done
nrc opened this issue Sep 18, 2017 · 5 comments
Closed
6 tasks done

Tracking issue: skip attributes #1978

nrc opened this issue Sep 18, 2017 · 5 comments
Labels
blocked Blocked on rustc, an RFC, etc.
Milestone
1.0 (edition rc1)

Comments

@nrc
Copy link
Member

nrc commented Sep 18, 2017 •
edited
Loading

RFC 2103 will let us use #[rustfmt::skip] without a warning.

  • merge RFC 2103 (nrc)
  • implement the new scoped attributes in Rust
  • recognise the scoped attributes in rustfmt
  • document and recommend the new attributes
  • stabilise the new attributes in Rust
  • deprecate the old attributes
@nrc nrc added the p-high label Sep 18, 2017
@nrc nrc added this to the impl period milestone Sep 18, 2017
@nrc nrc mentioned this issue Sep 18, 2017
Closed
10 tasks
@topecongiro topecongiro mentioned this issue Dec 8, 2017
Merged
@nrc nrc modified the milestones: impl period, 1.0 Jan 11, 2018
@nrc
Copy link
Member Author

nrc commented Mar 4, 2018

There is an implementation at rust-lang/rust#47773 but it needs a test fixing and a rebase.

@nrc nrc mentioned this issue May 14, 2018
Merged
@nrc nrc added blocked Blocked on rustc, an RFC, etc. and removed p-high labels May 17, 2018
@nrc
Copy link
Member Author

nrc commented Jun 30, 2018 •
edited
Loading

See rust-lang/rust#51277 which is a bug in the scoped attributes implementation.

@nrc
Copy link
Member Author

nrc commented Jul 17, 2018

Update still blocked on FCP and fixing 51277. I've pinged people...

@nrc nrc modified the milestones: 1.0 (preview 2), 1.0 (rc) Aug 3, 2018
@topecongiro
Copy link
Contributor

rust-lang/rust#51277 is closed 🙌

@nrc
Copy link
Member Author

nrc commented Aug 28, 2018

skip attributes are stable and will ride the trains, closing.

@nrc nrc closed this as completed Aug 28, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
blocked Blocked on rustc, an RFC, etc.
Projects
None yet
Milestone
1.0 (edition rc1)
Development

No branches or pull requests
2 participants
@nrc @topecongiro