Skip to content

cleanup wasm const fn #1660

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

cleanup wasm const fn #1660

merged 1 commit into from
Oct 28, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Oct 25, 2024

We shouldn't need these feature gates any more, that was just an attempt at a transition that didn't quite work out.

@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@RalfJung RalfJung changed the title attempt to fix wasm const fn cleanup wasm const fn Oct 26, 2024
@RalfJung
Copy link
Member Author

Okay the try run here confirms that this will indeed work, so -- this should be good to go. :)

@Amanieu
Copy link
Member

Amanieu commented Oct 26, 2024

Should we wait until the rustc fix lands for #1661 or is the allow still needed?

@RalfJung
Copy link
Member Author

RalfJung commented Oct 26, 2024 via email

@RalfJung
Copy link
Member Author

RalfJung commented Oct 27, 2024

The new allow should be unnecessary with today's nightly, so I removed them.

@Amanieu Amanieu enabled auto-merge (rebase) October 28, 2024 07:25
@Amanieu Amanieu merged commit ff9a444 into rust-lang:master Oct 28, 2024
33 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants