Skip to content

Remove BLAS from linfa-clustering #255

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
YuhanLiin opened this issue Oct 30, 2022 · 1 comment
Closed

Remove BLAS from linfa-clustering #255

YuhanLiin opened this issue Oct 30, 2022 · 1 comment

Comments

@YuhanLiin
Copy link
Collaborator

Note that the only part of linfa-clustering that uses BLAS routines is Gaussian Mixture, which didn't actually show a difference in the benchmarks. For other modules, BLAS only changes the matrix multiplication algorithm. BLAS only speeds up the appx_dbscan benchmark, but actually slows down several other benchmarks. As such, BLAS doesn't actually benefit linfa-clustering, so it should be removed.

The linfa-clustering benchmarks are linked in this comment.

@oojo12
Copy link
Contributor

oojo12 commented Nov 1, 2022

I think we can close this now, per the above merge. My bad for not properly linking that PR to this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants