From 8cbc3487d815c08a81c92029121327ab28677c43 Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Sat, 3 Aug 2024 09:21:14 +0200 Subject: [PATCH 1/3] ci: Remove duplicated test in cargo-careful ndarray-rand test now included in workspace test on line before. --- .github/workflows/ci.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 16228b6bd..761f6b1cd 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -122,7 +122,6 @@ jobs: - name: Install cargo-careful run: cargo install cargo-careful - run: cargo careful test -Zcareful-sanitizer --features="$FEATURES" - - run: cargo careful test -Zcareful-sanitizer -p ndarray-rand docs: if: ${{ github.event_name == 'merge_group' }} From 98c2f25f4a0b45f23e50a47f60df636695a1a071 Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Sat, 3 Aug 2024 09:25:42 +0200 Subject: [PATCH 2/3] ci: Require nostd build Require this for ci to pass, and shorten the name. --- .github/workflows/ci.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 761f6b1cd..6771fc24b 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -42,7 +42,7 @@ jobs: components: rustfmt - run: cargo fmt --all --check - nostd-build: + nostd: runs-on: ubuntu-latest continue-on-error: ${{ matrix.experimental }} strategy: @@ -52,7 +52,7 @@ jobs: experimental: false target: thumbv6m-none-eabi - name: nostd-build/${{ matrix.target }}/${{ matrix.rust }} + name: nostd/${{ matrix.target }}/${{ matrix.rust }} steps: - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable @@ -142,6 +142,7 @@ jobs: needs: - clippy # - format # should format be required? + - nostd - tests - cross_test - cargo-careful From 3de33e4f5a3a0335d7957347864f8c69a8dc073d Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Sat, 3 Aug 2024 09:27:17 +0200 Subject: [PATCH 3/3] ci: Require rustfmt check --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 6771fc24b..88c9a6c2d 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -141,7 +141,7 @@ jobs: conclusion: needs: - clippy - # - format # should format be required? + - format # should format be required? - nostd - tests - cross_test