Skip to content

Port test from rand_pcg to rand_chacha #1185

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
vks opened this issue Sep 16, 2021 · 4 comments
Closed

Port test from rand_pcg to rand_chacha #1185

vks opened this issue Sep 16, 2021 · 4 comments
Labels
P-low Priority: Low

Comments

@vks
Copy link
Collaborator

vks commented Sep 16, 2021

This would allow us to move rand_pcg to the rngs repository, see #1139.

@vks vks added the P-low Priority: Low label Sep 16, 2021
@dhardy
Copy link
Member

dhardy commented Sep 17, 2021

I'm not convinced this is a good idea: (1) there's very little actual incentive to move rand_pcg to the rngs repo, and (2) PCG is a much simpler RNG than ChaCha, thus if we ever decided to replace ChaCha we'd have to port tests again instead of just keeping a small RNG around for tests.

So my vote is to close this and forget about the issue.

@vks
Copy link
Collaborator Author

vks commented Sep 17, 2021

I don't have a strong opinion either way. @newpavlov What do you think?

@newpavlov
Copy link
Member

I have a slight preference towards porting tests to rand_chacha, but I am fine with leaving everything as-is.

@dhardy
Copy link
Member

dhardy commented Sep 29, 2021

Given the responses I'll close this. If more reasons come up we can reconsider.

@dhardy dhardy closed this as completed Sep 29, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
P-low Priority: Low
Projects
None yet
Development

No branches or pull requests

3 participants