Skip to content

Check usefulness of tests #267

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
2 tasks
dhardy opened this issue Feb 22, 2018 · 2 comments
Closed
2 tasks

Check usefulness of tests #267

dhardy opened this issue Feb 22, 2018 · 2 comments
Labels
E-easy Participation: easy job

Comments

@dhardy
Copy link
Member

dhardy commented Feb 22, 2018

Several distribution tests merely generate a sample then discard it, e.g. test_normal. This checks that the syntax is still functional and that no internal asserts happened, but is probably not very useful.

  • Remove useless tests
  • Create tracker issue(s) for desired test functionality (or implement)

Also see: dhardy#72

@dhardy
Copy link
Member Author

dhardy commented Feb 22, 2018

Also note that some tests are duplicated due to replacing ind_sample with sample everywhere; duplicates can be removed.

@dhardy
Copy link
Member Author

dhardy commented May 14, 2019

Work on this isn't complete, but I don't see any value in keeping the issue open. #357 is the more useful tracker.

@dhardy dhardy closed this as completed May 14, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
E-easy Participation: easy job
Projects
None yet
Development

No branches or pull requests

1 participant