Skip to content

Consider pruning gen_ascii_chars #46

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
eternaleye opened this issue Apr 16, 2015 · 5 comments
Closed

Consider pruning gen_ascii_chars #46

eternaleye opened this issue Apr 16, 2015 · 5 comments
Labels
B-API Breakage: API

Comments

@eternaleye
Copy link

It seems to only be used in tests of its functionality, and is a bit specific for a method on every RNG.

@nagisa
Copy link
Contributor

nagisa commented Apr 16, 2015

It has a default implementation so you’re free to ignore it even if you’re implementing your own random number generator.

@eternaleye
Copy link
Author

Sure, but it's a highly purpose-specific call, with a misleading name (it generates A-Za-z0-9, not any ASCII), on a very general type.

@SimonSapin
Copy link
Contributor

I was about to file a new issue, but this will do. I saw gen_ascii_chars mentioned on reddit and expected it to generate in the U+0000 to U+007F range. It turns out it doesn’t.

If this is not removed, it should be renamed to gen_ascii_alphanumeric or gen_ascii_alphanumeric_chars. ("Alphanumeric" in one word is already used in char::is_alphanumeric.)

@psyomn
Copy link

psyomn commented Nov 23, 2015

I can do the above change if someone agrees.

If we do agree, should we leave both functions for now (rea, and a proxy renamed method), where the older depracated one will print an annoying message to the user? Maybe relevant linky.

@alexcrichton alexcrichton added the B-API Breakage: API label Jun 14, 2017
@pitdicker
Copy link
Contributor

With #279 gen_ascii_chars is now deprecated and replaced with an Alphanumeric distribution.

@dhardy dhardy closed this as completed Mar 3, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
B-API Breakage: API
Projects
None yet
Development

No branches or pull requests

7 participants