Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Better interoperability with x509-parser #135

Open
matejcik opened this issue Jul 19, 2023 · 2 comments
Open

Better interoperability with x509-parser #135

matejcik opened this issue Jul 19, 2023 · 2 comments

Comments

@matejcik
Copy link

It should be possible to generate CertificateParams from an X509Certificate directly, instead of having to go through DER decode/encode. Also methods like DistinguishedName::from_name are private while they could presumably be public.

@matejcik
Copy link
Author

instead of having to go through DER decode/encode

ah, even worse, x509-parser can't actually serialize, so if I throw away the incoming DER representation, I'm hosed :(

@est31
Copy link
Member

est31 commented Jul 20, 2023

Right now, I think there is zero dependence in the public API on x509-parser types, in other words, we could theoretically replace that crate completely and it wouldn't break user code (outside of potential behaviour changes). Improving interop would prevent that flexibility. Also, a semver breaking upgrade of x509-parser would now be one for rcgen, too.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants