Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove outdated quicli comments from init.rs #191

Closed
data-pup opened this issue Jun 18, 2018 · 1 comment · Fixed by #193
Closed

Remove outdated quicli comments from init.rs #191

data-pup opened this issue Jun 18, 2018 · 1 comment · Fixed by #193
Labels
to-do stuff that needs to happen, so plz do it k thx
Milestone

Comments

@data-pup
Copy link
Member

Now that quicli is not in the dependencies, the comments above init::create_pkg_dir are outdated. Further, I believe the full paths to result::Result are no longer needed in the various function/method definitions, since that conflict is no longer caused by quicli::prelude.

Assuming I'm right about all of that, I was thinking this could be a pretty straightforward thing to fix, and a good task for someone new to OSS contribution. I can take care of this tomorrow if that sounds good to you, I'll was planning to use it as a pairing exercise with someone 😄

@ashleygwilliams ashleygwilliams added the to-do stuff that needs to happen, so plz do it k thx label Jun 19, 2018
@ashleygwilliams
Copy link
Member

go for it @data-pup - i saw them but just had etoomany things on the brain- this would be greatly appreciated and i love that you'll use it as a pairing sesh!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants