Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incorrect package.json generated #854

Closed
rllola opened this issue Jun 1, 2020 · 3 comments
Closed

Incorrect package.json generated #854

rllola opened this issue Jun 1, 2020 · 3 comments

Comments

@rllola
Copy link

rllola commented Jun 1, 2020

Describe the Bug

I believe the package.json generated is missing a file in files when the target is browser.

Expected Behavior

I expect to have a filecoin_signer_wasm_bg.js

 "files": [
    "filecoin_signer_wasm_bg.wasm",
    "filecoin_signer_wasm.js",
    "filecoin_signer_wasm_bg.js"
  ],

Actual Behavior

What I actually have

  "files": [
    "filecoin_signer_wasm_bg.wasm",
    "filecoin_signer_wasm.js"
  ],

Additional Context

Then when publising to npm I am missing this file.

@Pauan
Copy link
Contributor

Pauan commented Jun 4, 2020

Thanks for the report, this is a duplicate of #837

@Pauan Pauan closed this as completed Jun 4, 2020
@lalberge
Copy link

lalberge commented Oct 8, 2020

You seemed to have close both issues while not fixing any :)

@Pauan
Copy link
Contributor

Pauan commented Oct 8, 2020

@lalberge The issue was closed because it was fixed. But I can't do a release because only @ashleygwilliams has permission to do that, and she has gone missing.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants