Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add function for the addition of two matrices #177

Merged
merged 4 commits into from
Oct 18, 2021

Conversation

shi27feng
Copy link
Contributor

Hi,
Maybe it's trivial to have this function, but I still think it'll be helpful and it looks neat when applying matrix addition, i.e., C = A + B.
Thanks

Hi,
Maybe it's trivial to have this function, but I still think it'll be helpful and it looks neat when applying matrix addition, i.e., C = A + B.
Thanks
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #177 (8444f41) into master (28f1295) will decrease coverage by 0.86%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   68.86%   68.00%   -0.87%     
==========================================
  Files          27       26       -1     
  Lines        1092     1072      -20     
==========================================
- Hits          752      729      -23     
- Misses        340      343       +3     
Impacted Files Coverage Δ
torch_sparse/storage.py 20.58% <ø> (ø)
torch_sparse/spadd.py 50.00% <50.00%> (ø)
torch_sparse/add.py 65.07% <84.37%> (+11.74%) ⬆️
torch_sparse/__init__.py
torch_sparse/utils.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f1295...8444f41. Read the comment docs.

@rusty1s
Copy link
Owner

rusty1s commented Oct 18, 2021

This is great. Thank you!

@rusty1s rusty1s merged commit 7c15c3c into rusty1s:master Oct 18, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants