-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Sort Colors into the correct names / Figure out a way to fix contrast #25
Comments
Interesting article about the subject I guess it might be enought to compare the RGBvalues. |
can i work on this? is there a deadline? |
Since the issue is 1.5 years old and has the label up-for-grabs I think you could just go for it. Do you know how you want to handle this? |
not really, i would like to understand more about the bug, i asked because of the k means parser label |
@shreab373 you can definetely contribute, but this is not a bug but a rather major feature. It is If you used themer you probably noticed that lots of colorschemes selected from images are not very useful with default terminal configs, because the contrast doesn't really work out. Basically what is needed would be to either sort the colors so that there is a way to use any themer colorscheme and always have some contrast (and ideally even match the color names more or less, at least dark/bright). Another problem is that sometimes the colors themselves just have no contrast, so maybe the color generation needs to be adjusted too. |
but not sure if i can do this, bu thank you letting me know that its a feature:) |
Is this issue still being worked on? I'm more of a WebDev but learning Python (learned JS, Java, C#). I would like to try and work on this :) |
@zybex86 I am not aware of anyone pursuing this currently, if you want to investigate this I'd be happy to see what you come up with :) |
I'm still looking into this, but I don't think it's a beginner-friendly issue ;) |
I am still having problems using themer to test how it works. For the time being I will drop this issue - will come back to it when I get more experienced with themer |
Either sort colors to the nearest correct name (
red
,green
,bright_blue
etc.) or find a way to label the colors so that there are obvios ways to use them and have readable contrast; for example sorting them in pairs (color1_dark
,color1_light
).The text was updated successfully, but these errors were encountered: