Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Viddy should check for ~/.bash_profile/~/*.shell*_profile as well as ~/.profile #164

Open
excited-bore opened this issue Nov 13, 2024 · 2 comments

Comments

@excited-bore
Copy link

excited-bore commented Nov 13, 2024

As referenced by sachaos #2 (comment), aliases need to be referenced in ~/.profile before viddy acknowledges them, but the thing is that certain aliases are shell-type specific.

Also alias in bash and zsh are differently build (alias in zsh has options and stuff)

@excited-bore excited-bore changed the title @Croissong @davidandradeduarte I've added new options --shell, --shell-options in v0.1.8 . Viddy should check for ~/.bash_profile/~/*shell_profile* as well as ~/.profile Nov 13, 2024
@excited-bore excited-bore changed the title Viddy should check for ~/.bash_profile/~/*shell_profile* as well as ~/.profile Viddy should check for ~/.bash_profile/~/*shell*_profile as well as ~/.profile Nov 13, 2024
@excited-bore excited-bore changed the title Viddy should check for ~/.bash_profile/~/*shell*_profile as well as ~/.profile Viddy should check for ~/.bash_profile/~/*.shell*_profile as well as ~/.profile Nov 13, 2024
@sachaos
Copy link
Owner

sachaos commented Nov 23, 2024

@excited-bore Thank you!
Are those profile not loaded by specifying --login option?

@excited-bore
Copy link
Author

excited-bore commented Nov 23, 2024

(in `~/.bash_aliases.d/general.sh`, wich is sourced in `~/.bash_aliases`, which in turn is sourced in `~/.bash_profile`) 
alias ls="eza --header --color=always --icons"

After a reboot:

$ viddy --shell '/bin/bash' --shell-options "--login" ls
viddy error: Something went wrong
Error: 
   0: No command provided

EDIT: I added [ -f ~/.bash_aliases.d/general.sh ] && source ~/.bash_aliases.d/general.sh - a line to source a file with aliases - to ~/.bash_profile and it still resulted in the same error.
Works great when i source it in ~/.profile

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants