Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

History is full of "nothing has changed" entries #41

Closed
leapfog opened this issue May 18, 2022 · 9 comments · Fixed by #99
Closed

History is full of "nothing has changed" entries #41

leapfog opened this issue May 18, 2022 · 9 comments · Fixed by #99

Comments

@leapfog
Copy link

leapfog commented May 18, 2022

I'm watching long running processes that change their output at not foreseeable times. So my History is filled with lots of "$timestamp +0 -0" entries. Can viddy be configured to not create these "nothing has changed" entries?

@TonyStark
Copy link

Same problem
Using curl with json output
but it seems curl not executing after sometimes.

@abhaysp95
Copy link
Contributor

Hi, @TonyStark @leapfog

If you guys can provide a gif/video or some steps to reproduce. I'm giving an example and tell me if it's correct. When I watch ls with viddy, and check history it give "$timestamp +0 -0", so what you guys want is to not add it history unless, there's a change (for example, someone added or removed file from the directory which I'm checking with ls and viddy)

@TonyStark
Copy link

however i left that project which i used viddy to watch data.

@leapfog
Copy link
Author

leapfog commented Dec 26, 2022

@coolabhays yes that's exactly my usecase. Or a perfect example for my problem. I want to know what and when changed. But when the delay is to small, the history is full of "$timestamp +0 -0" (and only one or two really interesting "real" changes, which then are difficult to scroll to) and when the delay is huge, I cannot see when changes really happened. So I'd prefer just not to add entries to the history unless there really was a change in the output.

@ilyagr
Copy link
Contributor

ilyagr commented Feb 7, 2023

You can check out https://github.com/blacknon/hwatch. It's less polished than viddy in some ways, but it doesn't suffer from this particular problem.

@ahmetb
Copy link

ahmetb commented Jul 25, 2023

Has anyone tried sending a PR?
IMO hwatch's diffing abilities are far worse than viddy, so I think this project deserves this change.

@abhaysp95
Copy link
Contributor

I've commited the initial change. I am also noticing the occasional flickering issue. It's possible that I may have to do more changes in the source code compared to what I would've liked.

Anyways, test this, and see if this is the intended behavior. I'll try to fix it more (if possibly needed) when I'll get some time again

@avamsi
Copy link
Contributor

avamsi commented Sep 11, 2023

I'll probably get back to it, but just in case I don't, avamsi@c62b260 seems to be working okay (i.e., the keyboard shortcuts and all) but there seems to be an off by one selection bug (on history update).

@ahmetb
Copy link

ahmetb commented Oct 15, 2023

Thanks for fixing this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants