From 2080d690ad1a18416da5e12442d1b192b8379463 Mon Sep 17 00:00:00 2001 From: "Sachin D. Shinde" Date: Fri, 16 Aug 2024 08:08:53 -0700 Subject: [PATCH] Revert non-test changes in https://github.com/graphql/graphql-js/pull/3442 , which introduced the bugged compareFragmentPairs usage --- .../rules/OverlappingFieldsCanBeMergedRule.ts | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/validation/rules/OverlappingFieldsCanBeMergedRule.ts b/src/validation/rules/OverlappingFieldsCanBeMergedRule.ts index 851f7ea625..607bb85c28 100644 --- a/src/validation/rules/OverlappingFieldsCanBeMergedRule.ts +++ b/src/validation/rules/OverlappingFieldsCanBeMergedRule.ts @@ -270,22 +270,6 @@ function collectConflictsBetweenFieldsAndFragment( // (E) Then collect any conflicts between the provided collection of fields // and any fragment names found in the given fragment. for (const referencedFragmentName of referencedFragmentNames) { - // Memoize so two fragments are not compared for conflicts more than once. - if ( - comparedFragmentPairs.has( - referencedFragmentName, - fragmentName, - areMutuallyExclusive, - ) - ) { - continue; - } - comparedFragmentPairs.add( - referencedFragmentName, - fragmentName, - areMutuallyExclusive, - ); - collectConflictsBetweenFieldsAndFragment( context, conflicts,