Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support FLINT 2.8.0 #32175

Closed
mkoeppe opened this issue Jul 10, 2021 · 18 comments
Closed

Support FLINT 2.8.0 #32175

mkoeppe opened this issue Jul 10, 2021 · 18 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 10, 2021

flint-2.8.0-beta1 was released 2021-07-09 https://groups.google.com/g/sage-devel/c/EPoTzfCz3lg/m/aofwmlpWAAAJ

This ticket serves as the target ticket of the proposed portability testing workflow for FLINT (flintlib/flint#972)

A patch to arb is required.

Test ticket with the FLINT upgrade: #32211

Depends on #31525

CC: @dimpase @kiwifb @antonio-rojas

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: ff0c762

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32175

@mkoeppe mkoeppe added this to the sage-9.4 milestone Jul 10, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2021

comment:3

With #32211 I am getting

[arb-2.19.0] epsilon_arg.c:15:1: error: static declaration of 'fmpz_kronecker' follows non-static declaration
[arb-2.19.0] fmpz_kronecker(const fmpz_t a, const fmpz_t b)
[arb-2.19.0] ^
[arb-2.19.0] /Users/mkoeppe/s/sage/sage-rebasing/worktree-rebase/.tox/local-homebrew-macos-minimal/local/include/flint/fmpz.h:648:15: note: previous declaration is here
[arb-2.19.0] FLINT_DLL int fmpz_kronecker(const fmpz_t a, const fmpz_t n);
[arb-2.19.0]               ^
[arb-2.19.0] 1 error generated.
[arb-2.19.0] make[6]: *** [../build/acb_modular/epsilon_arg.lo] Error 1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

Branch: u/mkoeppe/support_flint_2_8_0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

New commits:

2d4a805build/pkgs/arb/patches: Add https://github.com/fredrik-johansson/arb/commit/b6c8032e2da1b19eb7c5a5f5c2f3372643e3d170

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

Commit: 2d4a805

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

comment:6

Tests with FLINT 2.8.0-rc2 on #31525 show no errors (with the arb patch included).
So it looks like with this ticket here we will be ready for systems shipping FLINT 2.8.x.

The actual upgrade in #31525 will need more work and can be delayed to Sage 9.5.

@dimpase
Copy link
Member

dimpase commented Jul 18, 2021

comment:8

lgtm

@dimpase
Copy link
Member

dimpase commented Jul 18, 2021

Reviewer: Dima Pasechnik

@kiwifb
Copy link
Member

kiwifb commented Jul 18, 2021

comment:9

Normally adding a patch requires a revision bump.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 18, 2021

Changed commit from 2d4a805 to d8c9f4f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 18, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

d8c9f4fbuild/pkgs/arb/package-version.txt: Bump patch level

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 18, 2021

Changed commit from d8c9f4f to ff0c762

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 18, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ff0c762build/pkgs/arb/package-version.txt: Bump patch level

@kiwifb
Copy link
Member

kiwifb commented Jul 19, 2021

comment:13

Good.

@vbraun
Copy link
Member

vbraun commented Jul 24, 2021

Changed branch from u/mkoeppe/support_flint_2_8_0 to ff0c762

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants