Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

membership testing for ideals of quotient rings #33237

Closed
yyyyx4 opened this issue Jan 28, 2022 · 7 comments
Closed

membership testing for ideals of quotient rings #33237

yyyyx4 opened this issue Jan 28, 2022 · 7 comments

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Jan 28, 2022

Currently, the following code fails with a NotImplementedError:

sage: 1 in Zmod(15).ideal([3,5])

This patch implements ideal membership testing for quotient-ring ideals.

Component: algebra

Author: Lorenz Panny

Branch/Commit: cb02e3f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33237

@yyyyx4 yyyyx4 added this to the sage-9.6 milestone Jan 28, 2022
@tscrim
Copy link
Collaborator

tscrim commented Feb 15, 2022

comment:2

You might be better/faster to extend() the list rather than using concatenation. Otherwise LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Feb 15, 2022

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 15, 2022

Changed commit from a4b7b5f to cb02e3f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 15, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

19272fdMerge tag '9.6.beta1' into public/ideal_membership_testing_for_quotient_rings
cb02e3fextending list in-place should be slightly faster

@yyyyx4
Copy link
Member Author

yyyyx4 commented Feb 15, 2022

comment:4

Thank you, done.

@tscrim
Copy link
Collaborator

tscrim commented Feb 15, 2022

comment:5

Thank you.

@vbraun
Copy link
Member

vbraun commented Feb 20, 2022

Changed branch from public/ideal_membership_testing_for_quotient_rings to cb02e3f

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants