Chunk streamer crashes server on automatic update #205
Comments
|
I also have crashes on the latest version. |
|
I am also on 2.8.2 because of stability issues with the last versions |
|
As with #194, it might help if you compile the plugin with debug symbols ( Also, can anyone else confirm that 2.8.2 works fine? |
|
samp-incognito, can you compile a plugin with this key? I unfortunately do not know how to do this... |
Same problem with 2.8.2 version, same crash info. |
|
At me on v2.8.2 problems were not. Everything appeared after the addition of the actors. |
|
The debug version is here: https://github.com/samp-incognito/samp-streamer-plugin/releases/download/v2.9.1/streamer-debug.so |
|
How can I see the log of the debug version of the plug-in? |
|
Maybe it's not related to this problem, but I have also noticed that in the new version objects attached to vehicle do not stream out when the virtual world is changed, they remain in the same place until you get out of the streaming distance. If I recall correctly previous versions were destroying the objects as soon as the player moved because the objects weren't in the same VW as the vehicle. |
|
Again the server fell.
|
Run the server in GDB ( Keep in mind that some amount of processing is done on each server tick by default in 2.9(.1), so the plugin will probably always be somewhere in the backtrace. Unless the plugin made one of the last few calls, it's more likely that something else caused the crash. If memory errors are the problem, however (as I believe to be the case), the backtrace might not be particularly helpful. It will only show the last time memory (de)allocation failed, which appears to be what's happening here. If anyone could also run Valgrind with the debug version of the plugin ( |
|
How can I be if I just rent a hosting and do not have access to the Linux console? |
|
When will this crash be fixed ??? |
|
You can't do that if using a host. Incognito can't fix this if you don't know when this is happening, how to reproduce it, but your latest shown crash backtrace is looking like #218's one. Could you try to go in your fullest (lots of objects, close to the visible items limit [by default it is set as 500 AFAIK]) server area and see if it crashes ? You could try to use the latest compiled commit, Incognito tried to fix something similar: |
|
@IstuntmanI |
|
To anyone having issues: try the version linked above. |
|
#218
|
|
I installed the updated version, the bug is not fixed! |
|
Another crash, a report with a crashdetect |
|
I cannot wait to use the dynamic actors. |
|
He can't make any stable version until he will find the source of these crashes. The only possible thing I think would be to remove the changes made in v2.9.1 related to ticks and chunks. These problems are coming from those new features for sure. So actors are crashing too, this means that the cause is some code that is the same for streaming objects/actors and probably others too. I think that the problem is somewhere in 6e6a09a or 4b79a4f. @samp-incognito: You should probably note the releases 2.9.0 and 2.9.1 as unstable on the releases page. I can't remember what crashes 2.9.1 fixed, but I think that it should be noted as a beta release, so you will release a better 2.9.1 eventually with this current crash fixed. |
|
I won't be able to fix it until I'm able to reproduce it myself and/or I receive more detailed information about the crashes. I've made some comments above about how this could be done. These crashdetect logs aren't very helpful, I'm sorry to say. It could have something to do with the chunk streaming code, although I have no idea why that would be the case. There were many other changes between 2.8.2 and 2.9.0 as well. I still think it's probable in some cases that the crashes are originating in some other script or plugin, but because 2.9.x operates on nearly every server tick now, the plugin simply shows up in every backtrace. I can't think of any reason at all for the code around As a last resort, I could try putting the original streaming code in and making chunk streaming toggleable. That's not the way I would prefer to solve this, but we can see if it makes any difference. |
|
This toggle could be a temporary work-around if that is the case. I had myself some crashes when updating further than 2.8.2. I would not be able to have the server up for more than 2-3 days maximum, where as right now I can have it up for weeks normally. |
|
A thought, maybe it's been considered before: would this project benefit from some form of unit testing and integration testing? Being a library it's awkward but you could a. write a basic test binary that loads the library and runs a set of tests or b. implement a flag to compile the library as a binary where the entrypoint runs tests. I just thought a more pragmatic approach using some form of fuzzing and mocking streamer updates would help debug this quicker than loading up the game and waiting for a crash to occur. |
|
I no longer have the strength, again the server shuts down when it's big online. I made a rollback to version 2.8.2, until this bug is fixed. I post the latest logs, which I would like to somehow help and will wait for further updates. |
|
So Incognito made another commit: f3e1c5e . Here is the new download for both Linux and Windows (now with compatibility with Windows XP, if anyone actually needs that - @karimcambridge 😁 ?): https://mega.nz/#!W0I30a5D!4EQaaTKgbON7uFX2t-vtHjSPUT64j7lJixhARNDAiL8 @rt-2 You should still test the previous build, the one you already have, so you can actually give us that better backtrace. After it crashes, you should use this newer build and see if it still crashes to you. By the way, this plugin compiles really really slow (Intel Core i7-4510U). @samp-incognito: maybe you can configure Travis and AppVeyor and make them deploy the latest builds automatically, somehow ? [afaik it is possible] Not sure if this is possible for Windows too, you can check sampGDK and YSF, it would be great to have a "release" called "Newest Commit" with both linux and windows compiled files for the latest commit. |
|
Here we go again, for another week, not sure if will crash because there is not a lot of player during the week. |
|
This is weird to say, but 'unfortunatly, the server didn't crash for the whole week' |
|
We are running big server (180 players at this moment) on streamer 2.9.1 for month, on debian. |
|
I ran into a problem with the testing files, somehow when I run with this plugin the server has a CPU leak. So much that it becomes unplayable and unstable. |
|
@rt-2: Of course the debug version uses more CPU. It contains more information and it isn't optimized. @samp-incognito: I added lots of additional warnings ( so: samp-streamer-plugin/src/streamer.cpp Line 1019 in f3e1c5e samp-streamer-plugin/src/streamer.cpp Line 1338 in f3e1c5e samp-streamer-plugin/src/streamer.cpp Line 1808 in f3e1c5e I really think you made some mistakes with those bimaps, they are way too complex. Also, you maybe should fix these warnings I guess (there are few others too): Maybe you should take a look on all the gmake warnings, they may help. The warnings I provided are almost all the warnings of gmake enabled. Anyone else tried the compiled version of the latest commit ? In this issue: #230 they said that they are still seeing vanishing objects, but is it crashing anymore ? |
|
@IstuntmanI Personally I think the server wouldn't have spent a week opened for sure before, but I had more player and activity in these times. |
|
@IstuntmanI: Good point about the warnings. I'll investigate those. As for the bimaps, I'm not sure what's causing those particular warnings (I've not looked at the source yet), but they're only used in the chunk streaming code, which is disabled now by default. I'll see about fixing these warnings (if possible) and releasing 2.9.2 so that more people can test this. There are some bugs I've confirmed to be fixed since 2.9.1 was released anyway. |
|
I still think that you shouldn't release yet another version until this bug will be actually fixed. You should really add some "prelease"/"beta" one while updating the download with newer commits when available and then just change the release to a stable one when everything will be ok. You could also note there that there are two known bugs: objects vanishing and server crashes and if they have any information to provide about those problems they can visit and post in this issue. There's no need for a new version if it isn't stable, there's only the need for newest compiled commit on the releases page. |
|
I think people deserve more stability after all this time, I think a lot of bugs have been fixed/stabilized since 2.9.1, Yes we cannot release a 2.10.0, but we are ready for a 2.9.2? |
|
I'll add a note to the release and probably just mark everything post-2.8.2 as "beta", as you (@IstuntmanI) said. |
|
deserve? incognito barely ever opens sa-mp, tbh I have NO idea why he is still here. Why don't you guys look into actually helping him fix the bugs. You are scripting for your server, you can 'script' (lol) a streamer too. |
|
@karimcambridge I may have used the wrong word because I am not native english. |
|
@karimcambridge: Well, you aren't wrong. I haven't played SA-MP in several years. The only reason I still update this is because it solves a few interesting problems (I think so, anyway), but, most importantly, it does have a sizeable following. If nobody used it, I definitely would have stopped development a long time ago. I don't have much time to devote to it anymore, though, obviously. Of course, I'm always open to contributions. In fact, if other people wanted to take over development, they're welcome to do so. I can give them full access to the repository, provided I can verify who they are. (Anyone is welcome to fork it, too. I can link actively maintained forks on the wiki or even in the README.) The real problem, though, I guess, is that this community just doesn't have many developers to help, or at least it doesn't anymore. |
|
Who can check if the bug has been fixed in version 2.9.2? |
|
*** Error in./samp03svr': malloc(): memory corruption: 0x0b0ff90e *** |
|
@VinDieseLL: What version are you using? |
|
@samp-incognito 2.9.1 (debug) |
|
@VinDieseLL: Update to 2.9.2 and see if it fixes the problem for you. |
|
@samp-incognito I used v2.9.0 before for some days and pickups disappeared once for me and I downgraded to v2.8.2. Now I'm using v2.9.2 for quite some time already (didn't use v2.9.1) and everything is stable: no crash or item disappearing. The problem in my opinion is indeed somewhere in the |
|
New problem.`[21:36:30] [debug] Server crashed due to an unknown error |
|
@IstuntmanI: I think that's the case as well. I don't know how many people are using v2.9.2, but I haven't seen any reports of crashes yet. @VinDieseLL: It looks like you're still using that same version. You still have |
|
Hi, |
|
At me too on the last version all works without failures. |
samp-incognito
changed the title
|
I am on v.2.9.4 and chunk streaming still crashes the server until a random amount of time (1-4 weeks of no interruption). I will also be able to run Valgrind with the debug version of the plugin and see what happens. |
Hello!
for a week already I have problems with random server crashing. It's happening like 1-2 times a day, random hours and random player number.
server_log.txt file says:
Im my own hoster on VPS with newest debian 8, all dependencies are present, system is up-to-date.
As far I can see, its something in automatic update for players. I cant solve it on my own, so I decided to post it here, help appreciated.
What I tried:
Cheers.
The text was updated successfully, but these errors were encountered: