New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Option keys aren't optional with TypeScript #25

Closed

tolgaerdonmez opened this issue May 14, 2020 · 1 comment

Labels

bug

tolgaerdonmez commented May 14, 2020

export interface Options {
    pickerId?: string;
    families?: string[];
    categories?: Category[];
    scripts?: Script[];
    variants?: Variant[];
    filter?: (font: Font) => boolean;
    limit?: number;
    sort?: SortOption;
}

it would be better to set options to nullable, because it complains when using the module in typescript

samuelmeuli added the bug label

samuelmeuli changed the title ~~[REQUEST] FontPicker's OPTION types~~ Option keys aren't optional with TypeScript

samuelmeuli closed this as completed in

7ccd8d9

Owner

samuelmeuli commented May 16, 2020

Thanks for reporting! This should be fixed in v3.5.1.

# for free to join this conversation on GitHub. Already have an account? # to comment