safer way to rehydrate time

samvera-labs · Feb 13, 2025 · d4ca445 · d4ca445
1 parent 01dc6cd
commit d4ca445
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/controllers/bot_challenge_page/bot_challenge_page_controller.rb b/app/controllers/bot_challenge_page/bot_challenge_page_controller.rb
@@ -103,7 +103,7 @@ def self._bot_detect_passed_good?(request)
       datetime = session_data[SESSION_DATETIME_KEY]
       ip   = session_data[SESSION_IP_KEY]
 
-      (ip == request.remote_ip) && (Time.now - Time.new(datetime) < self.bot_challenge_config.session_passed_good_for )
+      (ip == request.remote_ip) && (Time.now - Time.iso8601(datetime) < self.bot_challenge_config.session_passed_good_for )
     end
 
 

diff --git a/spec/controllers/bot_challenge_page_controller_spec.rb b/spec/controllers/bot_challenge_page_controller_spec.rb
@@ -12,7 +12,7 @@
       expect(response.body).to eq turnstile_response.to_json
 
       expect(session[described_class.bot_challenge_config.session_passed_key]).to be_present
-      expect(Time.new(session[described_class.bot_challenge_config.session_passed_key][described_class::SESSION_DATETIME_KEY])).to be_within(60).of(Time.now.utc)
+      expect(Time.iso8601(session[described_class.bot_challenge_config.session_passed_key][described_class::SESSION_DATETIME_KEY])).to be_within(60).of(Time.now.utc)
 
       expect(described_class._bot_detect_passed_good?(controller.request)).to be true
     end