Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

🧹 Get model mappings all in place #2132

Merged
merged 1 commit into from
Jan 5, 2024
Merged

🧹 Get model mappings all in place #2132

merged 1 commit into from
Jan 5, 2024

Conversation

kirkkwang
Copy link
Collaborator

@kirkkwang kirkkwang commented Jan 5, 2024 •
edited
Loading

This commit will:

  • add extent to the image resource and form
  • override basic_metadata to show bibliographic_citation on forms
  • change PcdmObjectForm to ResourceForm because it was throwing errors
  • add bolding to labels on forms

Also:

  • Indexers were examined and no changes were needed
  • Presenters don't seem to be a default thing for Valkyrie works
  • Controllers were examined and no changes were needed
  • Views were examined and no changes were needed
  • Localizations don't seem to be a default thing for Valkyrie works

Ref:

houndci-bot
houndci-bot reviewed Jan 5, 2024
View reviewed changes
@kirkkwang kirkkwang force-pushed the i35-valkyrize-hyku-model-mappings branch 3 times, most recently from 18d43a7 to 259290c Compare January 5, 2024 19:19
🧹 Get model mappings all in place
11645aa 
This commit will:
  - add extent to the image resource and form
  - override basic_metadata to show bibliographic_citation on forms
  - change PcdmObjectForm to ResourceForm because it was throwing errors
  - add bolding to labels on forms

Also:
  - Indexers were examined and no changes were needed
  - Presenters don't seem to be a default thing for Valkyrie works
  - Controllers were examined and no changes were needed
  - Views were examined and no changes were needed
  - Localizations don't seem to be a default thing for Valkyrie works
@kirkkwang kirkkwang force-pushed the i35-valkyrize-hyku-model-mappings branch from 259290c to 11645aa Compare January 5, 2024 19:24
@kirkkwang kirkkwang added the patch-ver for release notes label Jan 5, 2024
This was referenced Jan 5, 2024
Closed
Closed
Closed
Closed
Closed
@kirkkwang kirkkwang merged commit feafeac into i35-valkyrize-hyku Jan 5, 2024
1 of 2 checks passed
@kirkkwang kirkkwang deleted the i35-valkyrize-hyku-model-mappings branch January 5, 2024 20:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@ShanaLMoore ShanaLMoore ShanaLMoore approved these changes

Assignees
No one assigned
Labels
patch-ver for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirkkwang @houndci-bot @ShanaLMoore