Use Marshal to serialize minter state rather than YAML #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
force-pushed
the
use_marshal_vs_yaml
branch
from
7bf5f2c to
e7b30df
Compare
mjgiarlo
changed the title
|
So if someone upgrades but doesn't run the migration what will happen? |
|
@cjcolvar 💣 (because I didn't want to write a checker that has to check on every single run) I was thinking this would be a new major version to reflect the breaking change. |
Because performance. See https://gist.github.com/mjgiarlo/1b09f710a625ffb92a8f#file-benchmark-results-with-marshal-serialization. Also provide a rake task for migrating an existing minter state file from YAML to Marshal format.
mjgiarlo
force-pushed
the
use_marshal_vs_yaml
branch
from
e7b30df to
58aaf5c
Compare
|
@cjcolvar I have also included a post_install_message on bundle that says "run the rake task or else" |
|
👍 |
cjcolvar
added a commit
that referenced
this pull request
Aug 6, 2015
Use Marshal to serialize minter state rather than YAML
|
👏 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because performance, especially for stateful minters with millions or billions of identifiers. See https://gist.github.com/mjgiarlo/1b09f710a625ffb92a8f#file-benchmark-results-with-marshal-serialization. Also provide a rake task for one-time migration of an existing minter state file from YAML to Marshal format.