Treeify algorithm should raise ArgumentError when passed nil or empty string #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolyncole
approved these changes
Oct 26, 2016
|
I think there are places that Sufia is using this code incorrectly. It should be getting errors, but it should get ArgumentError rather than NoMethodError. You should not pass an empty string to treeify. |
mjgiarlo
force-pushed
the
handle_empty_strings
branch
from
49fd7ea to
6476d99
Compare
mjgiarlo
force-pushed
the
handle_empty_strings
branch
from
6476d99 to
a9e0511
Compare
mjgiarlo
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.