Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dry::Types::Params::* missing from Valkyrie::Types #933

Open
cgalarza opened this issue Sep 13, 2023 · 1 comment
Open

Dry::Types::Params::* missing from Valkyrie::Types #933

cgalarza opened this issue Sep 13, 2023 · 1 comment

Comments

@cgalarza
Copy link
Contributor

Dry::Types::Params::* definitions are not included in Valkyrie::Types. I am not sure if this is intentional because all the other built-in dry-type classes listed here (besides Maybe types) are included. I think the definition of Valkyrie::Types::Params::ID might be overriding all the other Params definitions. I can get around it for now by using Dry::Types['params.nil'] so its not a huge problem, but I thought I would document it here. If this isn't the desired behavior I can look into how to fix it.

@tpendragon
Copy link
Collaborator

If you want to get the other Params types working, I think that'd be a great addition!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants