Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Version 0.6.2 #15

Merged
merged 14 commits into from
Jan 14, 2025
Merged

Version 0.6.2 #15

merged 14 commits into from
Jan 14, 2025

Conversation

DLBPointon
Copy link
Collaborator

Module update

Reverting CICD to original template style rather that my "download everything and run with singularity"

Updated documentation

Added a NONE value to valid input options for linting.

@DLBPointon DLBPointon added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 13, 2025
@DLBPointon DLBPointon self-assigned this Jan 13, 2025
Copy link

github-actions bot commented Jan 13, 2025

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c5bdd33

+| ✅ 114 tests passed       |+
#| ❔  34 tests were ignored |#
!| ❗  17 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: lib/WorkflowEar.groovy
  • files_exist - File not found: pyproject.toml
  • nextflow_config - Config manifest.version should end in dev: '0.6.2'
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
  • pipeline_todos - TODO string in nextflow.config: Specify your pipeline's command line flags
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-ear_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-ear_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-ear_logo_dark.png
  • files_exist - File is ignored: lib/nfcore_external_java_deps.jar
  • files_exist - File is ignored: lib/NfcoreSchema.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config variable ignored: params.show_hidden_params
  • nextflow_config - Config variable ignored: params.schema_ignore_params
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/nf-core-ear_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-ear_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-ear_logo_dark.png
  • files_unchanged - File does not exist: lib/nfcore_external_java_deps.jar
  • files_unchanged - File does not exist: lib/NfcoreSchema.groovy
  • files_unchanged - File does not exist: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/ear/ear/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2025-01-13 11:49:55

@DLBPointon
Copy link
Collaborator Author

Linting is not running at all

@muffato
Copy link
Member

muffato commented Jan 14, 2025

Maybe I'm late to the party, but I could see that all the CI jobs ran successfully, including the linting jobs. The problem was the PR merge rules were expecting CI jobs to be named a certain way.
I'm not sure why it didn't cause any issue on the previous PR onto dev. Anyway, I've updated the list of CI requirements based on what's actually running, and the PR should now be mergeable once approved.

@DLBPointon
Copy link
Collaborator Author

Great, thanks Matthieu.

@DLBPointon DLBPointon merged commit d4b0715 into main Jan 14, 2025
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants