Skip to content

Commit 8818d93

Browse files
authored
Properly override the sass-parser dependency on sass during release (#2487)
Previously we were loading the version variable after running `npm install sass@$version`, which caused the local path dependency not to be overwritten and consequently made the sass-parser package impossible to install.
1 parent adb7016 commit 8818d93

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

Diff for: .github/workflows/release.yml

+5-4
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,11 @@ jobs:
127127
check-latest: true
128128
registry-url: 'https://registry.npmjs.org'
129129

130+
- name: Get version
131+
id: version
132+
run: |
133+
echo "version=$(jq .version pkg/sass-parser/package.json)" | tee --append "$GITHUB_OUTPUT"
134+
130135
# The repo package has a file dependency, but the released version needs
131136
# a real dependency on the released version of Sass.
132137
- run: npm install sass@${{ steps.version.outputs.version }}
@@ -137,10 +142,6 @@ jobs:
137142
NODE_AUTH_TOKEN: '${{ secrets.NPM_TOKEN }}'
138143
working-directory: pkg/sass-parser/
139144

140-
- name: Get version
141-
id: version
142-
run: |
143-
echo "version=$(jq .version pkg/sass-parser/package.json)" | tee --append "$GITHUB_OUTPUT"
144145
- run: git tag sass-parser/${{ steps.version.outputs.version }}
145146
- run: git push --tag
146147

Diff for: pkg/sass-parser/CHANGELOG.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
## 0.4.9
22

3-
* No user-visible changes.
3+
* Add support for parsing the `@include` rule.
44

5-
## 0.4.8
5+
* Add support for parsing declarations.
66

7-
Add support for parsing the `@include` rule.
7+
## 0.4.8
88

9-
Add support for parsing the `@mixin` rule.
9+
* Add support for parsing the `@mixin` rule.
1010

11-
Add support for parsing the `@return` rule.
11+
* Add support for parsing the `@return` rule.
1212

1313
## 0.4.7
1414

Diff for: pkg/sass-parser/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
},
3333
"dependencies": {
3434
"postcss": ">=8.4.41 <8.5.0",
35-
"sass": "file:../../build/npm"
35+
"sass": "^1.83.1"
3636
},
3737
"devDependencies": {
3838
"@types/jest": "^29.5.12",

0 commit comments

Comments
 (0)