Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Node 13 support #2766

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Node 13 support #2766

merged 1 commit into from
Oct 23, 2019

Conversation

saper
Copy link
Member

@saper saper commented Oct 22, 2019

No description provided.

@saper saper force-pushed the node-modules-79 branch 2 times, most recently from 417ef1b to 4f6412c Compare October 22, 2019 18:37
appveyor.yml Show resolved Hide resolved
@saper saper force-pushed the node-modules-79 branch 2 times, most recently from 3eed4fd to 85be26c Compare October 22, 2019 19:47
@saper
Copy link
Member Author

saper commented Oct 22, 2019

DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the    
Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/

@saper saper changed the title [WIP] Node 13 support Node 13 support Oct 23, 2019
@saper saper mentioned this pull request Oct 23, 2019
3 tasks
@xzyfer xzyfer merged commit e84c6a9 into sass:master Oct 23, 2019

before_install:
- echo $TRAVIS_NODE_VERSION
- npm config set python `which python`
- if [ $TRAVIS_OS_NAME == "linux" ]; then
if [[ $(node -v) =~ v[1-9][0-9] ]]; then
if [[ $(node -v) =~ v13 ]]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to BUILDING.md we should be using gcc 6 also for node 12... II think we should change this

This was referenced Mar 12, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants