-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Get Java11 compatible #127 #128
Get Java11 compatible #127 #128
Conversation
EugenMayer
commented
Feb 14, 2019
- upgrade gradle to 5.2.2 and remove gradle install wrapper task, it is
- all tests are good (macosx and linux)
- also officeconverter does run with jodconverter on java11
Isn't it an upgrade to gradle 5.2.1 instead ? |
Yes sorry, mixed it up its 5.1.2
My tests are yet not representative, i had them run on 1.8 - testing 11.0 now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the commit message for 0d4d3e9
Upgrade gradle to 5.2.1 and remove gradle install wrapper task
The javadoc issue is probably related to https://bugs.openjdk.java.net/browse/JDK-8212233 @sepe81 we could just squash the whole PR later one and reduce it just to "j11 upgrade", or do you really want me to rebase that one commit? |
Ok tests are ok on 1.8 with gradle 5.1.2 but failing with java11 all 27 cli tests are failing
Seems like this is probably a mockito issue, which is stuck at 2.9.0 because of powermockitio
Not worked at all at powermockito, any comments? |
@EugenMayer Squashing later seems fine. 👍 Additionally I found a related open issue/suggestion for gradle: gradle/gradle#8267 |
travis Not sure https://docs.travis-ci.com/user/build-matrix/ is available for jdk though yet -> they are https://docs.travis-ci.com/user/languages/java/#build-matrix appveyor is wrong nodways since we have .//build.gradle: baselineJavaVersion = JavaVersion.VERSION_1_8 |
@EugenMayer Maybe https://stackoverflow.com/a/34874587 helps as a workaround for the javadoc problem? |
really what we want, i mean in terms do we want to disable those? |
Ok tests are failing properly now and reflect my javadoc issue, thats good :) |
@EugenMayer As I wrote -- it's just a workaround, maybe till there is a real solution for gradle with Java 11 |
@sepe81 https://stackoverflow.com/a/34874587 would work, but i guess that is not want is wanted - i need some more details of @sbraconnier on this. Still the cli tests are failing, are you both interested in working on this in general? |
Wow thanks for all the good work! I won't be able to check this until next week but I definitely want to get Java 11 compatibility! I'll get back to you. |
I finally had time to work on this! To summarize, I updated the PowerMock library, I changed the javadoc options in the Thanks for your contribution!! |
Thank you for your hard work once again! |
@sbraconnier just wanted to confirm that my j11 based builds are working now ( at https://github.com/EugenMayer/docker-image-jodconverter ) so it actually worked out well :) |
Glad to hear that!! 👍 |