Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: 'topic/subtopic' matches 'topic/subtopic/#' #241

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

steersbob
Copy link
Contributor

Resolves #239

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #241 (e8c0dd3) into main (3ad32f7) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #241   +/-   ##
=====================================
  Coverage   84.1%   84.1%           
=====================================
  Files          4       4           
  Lines        468     468           
  Branches      87      87           
=====================================
  Hits         394     394           
  Misses        47      47           
  Partials      27      27           
Files Changed Coverage Δ
aiomqtt/client.py 82.7% <100.0%> (ø)

@empicano
Copy link
Owner

empicano commented Aug 3, 2023

LGTM, nice that you updated the tests as well 👍

Thanks for another great contribution to aiomqtt!

@empicano empicano merged commit c2cc37f into empicano:main Aug 3, 2023
@steersbob steersbob deleted the fix/trailing-wildcard branch August 3, 2023 12:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topic topic/subtopic does not match wildcard topic/subtopic/#
2 participants