Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix python3.6 compatibility #57

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

fipwmaqzufheoxq92ebc
Copy link
Contributor

The library currently uses methods like get_running_loop(), which are only available in python>=3.7
This PR fixes that.

Fixes the downstream-issue flyte/mqtt-io#192

@flyte
Copy link
Collaborator

flyte commented Apr 6, 2021

Nice one @fipwmaqzufheoxq92ebc ! Looks good to me, but I'll hang on until @frederikaalund has a look 😃

@frederikaalund frederikaalund merged commit f7e1d23 into empicano:master Apr 7, 2021
@frederikaalund
Copy link
Collaborator

Thanks for this pull request. It looks good to me. 👍

Do note that asyncio-mqtt officially targets Python 3.7. However, in the spirit of pragmatism:

  • We'll gladly merge in small compatibility fixes like this (thanks for the contribution 👍)
  • We'll try not to break backwards compatibility (this is on a best-effort basis).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants