Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added a pure functional implementation of operator precedence parsing #470

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

peteraldous
Copy link

Submitted for discussion; needs tests and documentation.

@peteraldous
Copy link
Author

I don't particularly care for the fact that the Associativity enum lives outside of the Parsers trait, but I don't see a way to include it because of the binary compatibility constraints. It might be there's a simple solution and I'd be happy to find out about it.

@SethTisue SethTisue marked this pull request as draft April 5, 2023 11:33
@peteraldous
Copy link
Author

I'm still not seeing the same results when I run sbt test locally as the CI pipeline is showing. I've rebased on the new main (as this code is completely orthogonal to the changes there) and addressed the error I saw in the tests. I'll push again if I see more errors. Sorry about the commit spam; I don't know how to reproduce the same errors locally.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant