Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Yaml driver for the parameter xml_attribute_map is broken #141

Closed
mvanmeerbeck opened this issue Sep 5, 2013 · 2 comments
Closed

Yaml driver for the parameter xml_attribute_map is broken #141

mvanmeerbeck opened this issue Sep 5, 2013 · 2 comments

Comments

@mvanmeerbeck
Copy link
Contributor

Hi,

There is an error in the yaml driver for the attribute "xml_attribute_map"
YamlDriver.php, line 170

if (isset($pConfig['xml_attribute_map'])) {
                        $pMetadata->xmlAttribute = (Boolean) $pConfig['xml_attribute_map'];
                    }

Should be

if (isset($pConfig['xml_attribute_map'])) {
                        $pMetadata->xmlAttributeMap = (Boolean) $pConfig['xml_attribute_map'];
                    }

Copy, paste is our worst ennemy guys

@stof
Copy link
Contributor

stof commented Sep 5, 2013

Can you send a pull request with the fix (you should even be able to crate it with the online editing for such a small change) ? This way, the commit will be attributed to you

@mvanmeerbeck
Copy link
Contributor Author

Sorry, i'm new on github.
pull request done
#142

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants