Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle partially fixed parameters in model_utils API #390

Closed
alexander-held opened this issue Mar 21, 2023 · 1 comment · Fixed by #396
Closed

Handle partially fixed parameters in model_utils API #390

alexander-held opened this issue Mar 21, 2023 · 1 comment · Fixed by #396
Labels
bug Something isn't working

Comments

@alexander-held
Copy link
Member

The support for partially fixed parameters (such as staterror with zeros in some bins) in pyhf 0.7 can result in scenarios where the behavior of suggested_fixed_as_bool is undefined, see scikit-hep/pyhf#1944.

This currently breaks model_utils.prefit_uncertainties in cabinetry (and also affects model_utils.unconstrained_parameter_count). Working around this should be possible by iterating bin by bin for affected parameters and using the suggested_fixed API instead.

@alexander-held
Copy link
Member Author

model_utils.prefit_uncertainties can be fixed by using the suggested_fixed API. model_utils.unconstrained_parameter_count is not affected by constrained parameters, but needs in principle to be able to handle shapefactor modifiers that are partially fixed. This is not currently supported by pyhf on a workspace specification level (scikit-hep/pyhf#2053), but it would be good to already implement this in cabinetry such that it automatically works if support arrives in pyhf.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant