Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CI failing for iminuit v2.12.2 #1918

Closed
1 task done
matthewfeickert opened this issue Jul 16, 2022 · 2 comments · Fixed by #1919
Closed
1 task done

CI failing for iminuit v2.12.2 #1918

matthewfeickert opened this issue Jul 16, 2022 · 2 comments · Fixed by #1919
Assignees
@matthewfeickert
Labels
bug Something isn't working

Comments

@matthewfeickert
Copy link
Member

Summary

On 2022-07-15 iminuit v2.12.2 was released to "fix bug in error heuristic and prevent assigning non-positive values". With this release the CI is failing for tests/test_infer.py, tests/test_otim.py, tests/test_jit.py, tests/test_public_api.py, tests/test_scripts.py, and tests/test_validation.py

OS / Environment

All

Steps to Reproduce

Run the test suite in CI

File Upload (optional)

No response

Expected Results

CI to pass

Actual Results

All the above tests fail.

pyhf Version

`HEAD` which is currently 8e242c9c829963c714f9b10acd28494f004a2452

Code of Conduct

  • I agree to follow the Code of Conduct
@matthewfeickert matthewfeickert added bug Something isn't working needs-triage Needs a maintainer to categorize and assign labels Jul 16, 2022
@alexander-held
Copy link
Member

I saw the same for cabinetry, presumably due to scikit-hep/iminuit#762.

@matthewfeickert matthewfeickert mentioned this issue Jul 17, 2022
Merged
4 tasks
@matthewfeickert
Copy link
Member Author

This is also happening (understandably) in v2.13.0 given that it was released today.

@matthewfeickert matthewfeickert mentioned this issue Jul 26, 2022
Merged
4 tasks
@matthewfeickert matthewfeickert self-assigned this Aug 9, 2022
@matthewfeickert matthewfeickert removed the needs-triage Needs a maintainer to categorize and assign label Aug 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@matthewfeickert matthewfeickert

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Manually set uncertainties for fixed parameters to 0 scikit-hep/pyhf
2 participants
@matthewfeickert @alexander-held