Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Replace notion-sdk-jvm with custom Spring Rest Client #37

Closed
scordio opened this issue Jan 21, 2024 · 4 comments
Closed

Replace notion-sdk-jvm with custom Spring Rest Client #37

scordio opened this issue Jan 21, 2024 · 4 comments

Comments

@scordio
Copy link
Owner

scordio commented Jan 21, 2024

Currently, Notion SDK JVM is used as an underlying dependency to use the Notion API.

Although it gives the benefit of accessing the API from Java without additional effort, it has a few downsides:

  • Brings Gson and Kotlin transitively
  • Currently blocks the introduction of a module descriptor (Add module descriptor #14)
  • Could slow down the adoption of new API types released by Notion

An alternative could be to adopt one of the Rest Client options that Spring provides.

@sakshipatil1305
Copy link

is anyone working on this ?

@scordio
Copy link
Owner Author

scordio commented Oct 24, 2024

Hi @sakshipatil1305, not yet!

Before starting here, a few things are ongoing, including the move to the spring-batch-extensions repo (see #53 and spring-projects/spring-batch-extensions#147) which will lead to archiving this repository.

Plus, I have the feeling the integration tests should be improved before such a refactoring can be done, as more complex use cases are currently delegated to the dependency I'd like to remove.

Let me ping you once this topic is ready to be picked up, if you don't mind.

@fahmikudo
Copy link

Hi @scordio
Interested
Can you explain which part needs to be improved integration test? Or maybe there is an explanatory document?
Maybe if I have free time I will try to contribute.

Thanks

@scordio
Copy link
Owner Author

scordio commented Nov 8, 2024

Superseded by spring-projects/spring-batch-extensions#154.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants