From 0dbc007c07c869daaf63da780fcd36d20420e785 Mon Sep 17 00:00:00 2001 From: luogz17 Date: Sat, 9 Dec 2023 01:17:47 +0800 Subject: [PATCH] fix(workerpool.go): add nil check in AddTask method to prevent adding nil task to reduce the worker number. --- common/utils/workerpool/workerpool.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/common/utils/workerpool/workerpool.go b/common/utils/workerpool/workerpool.go index ee39647e7b..b57ae1bce8 100644 --- a/common/utils/workerpool/workerpool.go +++ b/common/utils/workerpool/workerpool.go @@ -26,12 +26,8 @@ func (vwp *WorkerPool) Run() { for i := 0; i < vwp.maxWorker; i++ { go func() { for task := range vwp.taskQueueChan { - if task != nil { - task() - vwp.wg.Done() - } else { - return - } + task() + vwp.wg.Done() } }() } @@ -46,6 +42,9 @@ func (vwp *WorkerPool) Stop() { // AddTask adds a task to WorkerPool func (vwp *WorkerPool) AddTask(task func()) { + if task == nil { + return + } vwp.wg.Add(1) vwp.taskQueueChan <- task }