Add all of the missing RPC apis #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liorbond
requested review from
Cashmaney,
reuvenpo,
toml01 and
assafmo
as code owners
assafmo
reviewed
Aug 21, 2022
| // Query contract hash by code id | ||
| rpc ContractHashByID (QueryContractHashByIDRequest) returns (QueryContractHashResponse) { | ||
| option (google.api.http).get = "/compute/v1beta1/hash/id/{code_id}"; | ||
| } | ||
| // Query contract key by address | ||
| rpc ContractKey(QueryContractKeyRequest) returns (QueryContractKeyResponse) { |
There was a problem hiding this comment.
Why? it was implemented in the querier but was missed here, If it's irrelevant ill remove it from the querier as well.
There was a problem hiding this comment.
Because it's used only inside the enclave, there's no reason to use it outside
assafmo
reviewed
Aug 21, 2022
| option (google.api.http).get = "/compute/v1beta1/key/{address}"; | ||
| } | ||
| // Query contract address by label | ||
| rpc AddressByLabel(QueryContractAddressByLabelRequest) returns (QueryContractAddressByLabelResponse) { |
There was a problem hiding this comment.
Should also add the other way around
There was a problem hiding this comment.
Working on it in another PR, this PR focus on those APIs that were implemented in the queried but weren't exported by the pb
liorbond
force-pushed
the
lior-expose-all-in-rpc
branch
from
d527b97 to
74fac1e
Compare
Cashmaney
approved these changes
Aug 23, 2022
Add missing RPC function and make proto file readable
|
Replaced by #1130 |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.