Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix broken build due to stdsimd feature being removed from nightly #142

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

sdd
Copy link
Owner

@sdd sdd commented Feb 9, 2024

the stdsimd unstable feature was recently removed from Rust nightly (rust-lang/rust#117372). This change updates Kiddo so that it will work with latest nightly, as well as stable. Older nightly builds are unsupported.

@sdd sdd force-pushed the fix-stdsimd-removal branch 2 times, most recently from 3d7cd2a to 56e8b54 Compare February 9, 2024 19:48
@sdd sdd force-pushed the fix-stdsimd-removal branch from 56e8b54 to 8aa4fae Compare February 15, 2024 06:50
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e2dbf4) 92.38% compared to head (202ab9f) 94.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   92.38%   94.01%   +1.63%     
==========================================
  Files          51       51              
  Lines        6197     5931     -266     
  Branches     6197     5931     -266     
==========================================
- Hits         5725     5576     -149     
+ Misses        442      334     -108     
+ Partials       30       21       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdd sdd merged commit ac93f35 into master Feb 15, 2024
11 checks passed
@sdd sdd deleted the fix-stdsimd-removal branch February 15, 2024 07:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants