Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove bumpversion and use bump-my-version #334

Closed
amontanez24 opened this issue Feb 26, 2024 · 0 comments · Fixed by #340
Closed

Remove bumpversion and use bump-my-version #334

amontanez24 opened this issue Feb 26, 2024 · 0 comments · Fixed by #340
Assignees
Labels
internal The issue doesn't change the API or functionality maintenance Tasks related to infrastructure & dependencies
Milestone

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented Feb 26, 2024

Problem Description

  • The bumpversion library is not a maintained library and we should switch to using bump-my-version.
    • Alternatively, we could also just use Python's native version management (relying on dev's to increment 1 file).

Expected behavior

  • Use bump-my-version to version bump sdv.
  • Alternatively, just specify the version in 1 location and have pyproject.toml read from that location.

Technical Details

Make sure the following commands work:

  • bumpversion candidate --no-tag
    This should bump to the next candidate version (eg. 1.1.1.dev0 -> 1.1.1.dev1)
  • bumpversion --no-tag patch
    This should bump to the next patch (eg. 1.1.1.dev0 -> 1.1.2.dev0)
  • bumpversion --no-tag minor
    This should bump to the next minor (eg. 1.1.0.dev0 ->1.2.0.dev0)
  • bumpversion --no-tag major
    This should bump to the next major version (eg. 1.1.0.dev0 -> 2.0.0.dev0)
  • bumpversion release --no-tag
    This should bump to a release version (Eg. 1.2.0.dev0 -> 1.2.0)

Don't run make bumpversion-patch or make bumpversion-release because those commands merge to stable. Just call bumpversion or bumpmyversion directly

@amontanez24 amontanez24 added internal The issue doesn't change the API or functionality maintenance Tasks related to infrastructure & dependencies labels Feb 26, 2024
@amontanez24 amontanez24 added this to the 0.10.0 milestone Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
internal The issue doesn't change the API or functionality maintenance Tasks related to infrastructure & dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants