Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Code Refactoring #215

Closed
fealho opened this issue Apr 7, 2023 · 0 comments · Fixed by #217
Closed

Code Refactoring #215

fealho opened this issue Apr 7, 2023 · 0 comments · Fixed by #217
Assignees
Labels
internal The issue doesn't change the API or functionality
Milestone

Comments

@fealho
Copy link
Member

fealho commented Apr 7, 2023

Description

SDGym requires some refactoring. In part due to issue #212, parts of the code are currently misplaced, unused or outdated.

That should be fixed in the following parts:

  • Create a _benchmark method which all benchmark_{modality} methods will call (add helper methods)
  • Delete the MODALITIES attribute
  • Delete SingleTableBaselineSynthesizer
  • Fix MultiSingleTableBaselineSynthesizer
  • Move all outdated code into a Legacy folder
  • Move all CLI-only code into a CLI folder
  • (Maybe) Convert all metadata objects into SingleTableMetadata/MultiTableMetadata
  • dataset.py logic should import from SDV
  • Remove SynthesizerMapping and rename SingleTablePreset to FastMLPreset
  • Add integration tests for all public methods
  • Review and update any incorrect docstrings/READMEs
  • Other minor fixes

These should all be merged into a separate branch, which will in turn be merged to master.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants