Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The returned Evaluate_Time does not include results from all metrics #310

Closed
npatki opened this issue Jun 10, 2024 · 0 comments · Fixed by #320
Closed

The returned Evaluate_Time does not include results from all metrics #310

npatki opened this issue Jun 10, 2024 · 0 comments · Fixed by #320
Assignees
Labels
bug Something isn't working
Milestone

Comments

@npatki
Copy link

npatki commented Jun 10, 2024

Environment Details

  • SDGym version: 0.8.0 (latest)

Error Description

According to the SDGym docs, the final results include a column called Evaluate_Time. This column is supposed to include the total time it took to evaluate the synthetic data, based on the metrics provided.

But in practice, we see that the Evaluate_Time computation is hardcoded such that it only ever includes the time to run the quality report, and the NewRowSynthesis metric (if provided):

SDGym/sdgym/benchmark.py

Lines 329 to 335 in 50eac8e

evaluate_time = None
if 'scores' in output or 'quality_score_time' in output:
evaluate_time = output.get('quality_score_time', 0)
for score in output.get('scores', []):
if score['metric'] == 'NewRowSynthesis':
evaluate_time += score['metric_time']

Expected Behavior

When running a benchmark, it is possible to input additional SDMetrics to be used for evaluation. If I add new metrics, I expect that the time it takes to compute them should be included in the final Evaluate_Time that is reported.

@npatki npatki added the bug Something isn't working label Jun 10, 2024
@lajohn4747 lajohn4747 self-assigned this Jul 1, 2024
@lajohn4747 lajohn4747 added this to the 0.8.0 milestone Jul 1, 2024
@amontanez24 amontanez24 modified the milestones: 0.8.0, 0.9.0 Aug 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants