Method with() on test doubles yields error with static analyzer

[nreynis]

Q	A
PHPUnit version	12
PHP version	8.3
Installation Method	Composer

Summary

This piece of code works, but does not pass static analysis anymore.

$this->createMock(MyService::class)
    ->method('get')
    ->with($id)
    ->willReturn($value);

The test still run correctly but does not pass a PHPStan analysis anymore:

Call to an undefined method
         PHPUnit\Framework\MockObject\Builder\InvocationStubber::with().

In PHPUnit 11 method returned an InvocationMocker

I can workaround by using willReturnMap, but I haven't seen any deprecation, or anything in the release notes. The documentation still has examples with the same construction (ie: https://docs.phpunit.de/en/12.0/test-doubles.html#id34).

Should I change my code or is this an unwanted side-effect of refactoring?

Current behavior

Fail static analysis

How to reproduce

See minimal example: https://github.com/nreynis/phpunit-6154

Expected behavior

[sebastianbergmann]

Thank you for your report.

Please provide a minimal, self-contained, reproducing test case that shows the problem you are reporting.

Without such a minimal, self-contained, reproducing test case I will not be able to investigate this issue.

[nreynis]

Sure here is a minimal example:
https://github.com/nreynis/phpunit-6154

[nreynis]

Thank you for the very quick response 💪

[sebastianbergmann]

You're welcome. Were you able to verify that the change solves your problem?

[nreynis]

Yes, I've just checked commit c9fa5f5504ca03cb9565e9130cfc87bc74b44910 and this version does work.

[smpn2]

@nreynis @sebastianbergmann Have you taken into consideration the following cases? I am having a different problem.

from https://github.com/nreynis/phpunit-6154

    public function testMockGet(): void
    {
        $mockedService = $this->createMock(MyService::class);

        $mockedService
+           ->expects($this->exactly(1))
            ->method('get')
            ->with(24)
            ->willReturn('24');

        $this->assertSame('24', $mockedService->get(24));
    }

------ ---------------------------------------------------------------------------------------------------- 
  Line   test\MyServiceTest.php
 ------ ----------------------------------------------------------------------------------------------------
  :16    Call to method method() on an unknown class PHPUnit\Framework\MockObject\Builder\InvocationMocker.
         🪪  class.notFound
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ ----------------------------------------------------------------------------------------------------

[sebastianbergmann]

I am having a different problem.

Please do not use an existing issue to discuss a new / different issue. If your issue still exists in PHPUnit 12.0.9 then please open a new issue. Thank you.

That being said, your issue might be related to PHPStan's cache (as PHPUnit 12.0.9 no longer has PHPUnit\Framework\MockObject\Builder\InvocationMocker). Delete PHPStan's cache and run again.

[smpn2]

@sebastianbergmann I'm Sorry. I created new issue. (#6156)