Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Required new line before typeof #15

Closed
ruiquelhas opened this issue Dec 17, 2015 · 0 comments
Closed

Required new line before typeof #15

ruiquelhas opened this issue Dec 17, 2015 · 0 comments
Assignees
Labels

Comments

@ruiquelhas
Copy link
Contributor

Currently, when the module tries to lint itself, we get the following error:

Keyword `typeof` should have an empty line above it at ./src/rules/require-should-assertion-execution.js :
    14 |const Assertion = should.Assertion.prototype;
    15 |const assertions = Object.keys(Assertion);
    16 |const chains = Object.keys(Assertion).filter(key => typeof Assertion[key] !== 'function');
-----------------------------------------------------------^
    17 |
    18 |/**

As far as I am aware, there is no good reason for this requirement, so we should just remove it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant