Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add ability to use an image on a cache miss #42

Open
ivotron opened this issue Jun 29, 2022 · 1 comment
Open

add ability to use an image on a cache miss #42

ivotron opened this issue Jun 29, 2022 · 1 comment

Comments

@ivotron
Copy link

ivotron commented Jun 29, 2022

first of all thanks a lot for this plugin! 🙇

if I understand correctly from reading the Design section of the README, the image is built from scratch on a cache miss, is this correct? What would it take to add the ability of having a tag that can be used to reference it in the --cache-from arg for docker build in the case of cache misses? would you be open to having a PR that adds this functionality?

thanks!

@gitlon
Copy link

gitlon commented Jul 4, 2022

@ivotron

a PR seems ok, but I think you can achieve what you want with the current plugin using additional-build-args, ref README?

eg:

steps:
  - command: echo hello
    plugins:
      - seek-oss/docker-ecr-cache#v2.0.0:
          additional-build-args: '--cache-from somereg/my-image:tag'
      - docker#v3.12.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants