fix(iOS): assign -> copy for numeric types #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinking
requested review from
f2prateek,
fathyb,
rarchana2001asu and
danielstjules
f2prateek
approved these changes
Jun 4, 2019
fathyb
approved these changes
Jun 4, 2019
| @@ -564,9 +565,35 @@ class AnalyticsObjectiveCWrapperRenderer extends ObjectiveCRenderer { | |||
| }) | |||
| } | |||
|
|
|||
| /** | |||
| * Always used the boxed types, because of a potential upstream bu with nullable values | |||
|
@f2prateek we're adding a harness for these kind of run-time tests in v7: #59 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue in iOS clients for required numeric values where the incorrect value was supplied to
analytics-ios.