Skip to content

failCommentCondition isnt checked for "success" step #1025

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
rhys-childs opened this issue Apr 14, 2025 · 1 comment · May be fixed by #1026
Open

failCommentCondition isnt checked for "success" step #1025

rhys-childs opened this issue Apr 14, 2025 · 1 comment · May be fixed by #1026

Comments

@rhys-childs
Copy link

rhys-childs commented Apr 14, 2025 •
edited by hearts bot
Loading

failComment is marked as deprecated, but failCommentCondition isn't actually checked in the success step like failComment was.

failCommentCondition was added to the config here

The deprecation warning was added to the fail step for failComment here

But the same check is not performed here

The result is that you have to use the deprecated failComment config value to disable issue checking on the success step.
@rhys-childs
Copy link
Author

rhys-childs commented Apr 14, 2025 •
edited by hearts bot
Loading

Ive opened a PR to resolve it

@babblebey babblebey linked a pull request Apr 14, 2025 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Check failCommentCondition in "success" step rhys-childs/github
1 participant
@rhys-childs