Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(glob-assets): remove unnecessary option when invoking globby() #924

Conversation

oscard0m
Copy link
Contributor

@oscard0m oscard0m commented Sep 13, 2024

📖 Description

remove unnecessary option when invoking globby(): gitignore: false

📚 Context

The default behaviour of gitignore option is false1

Footnotes

  1. https://github.com/sindresorhus/globby?tab=readme-ov-file#gitignore

@oscard0m oscard0m force-pushed the remove-globby-option-matching-default-behaviour branch 3 times, most recently from 8fe6688 to 3591be4 Compare September 13, 2024 22:23
@oscard0m oscard0m changed the title refactor(glob-assets): use 'tinyglobby' instead of 'globby' as dependency refactor(glob-assets): remove unnecessary option when invoking globby() Sep 13, 2024
gitignore: false is the default behaviour of globby
@oscard0m oscard0m force-pushed the remove-globby-option-matching-default-behaviour branch from 3591be4 to a7f18c0 Compare September 13, 2024 22:31
@oscard0m oscard0m changed the title refactor(glob-assets): remove unnecessary option when invoking globby() refactor(glob-assets): remove unnecessary option when invoking globby() Sep 13, 2024
Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@travi travi changed the title refactor(glob-assets): remove unnecessary option when invoking globby() fix(glob-assets): remove unnecessary option when invoking globby() Sep 15, 2024
@travi travi merged commit efe9f49 into semantic-release:master Sep 15, 2024
6 checks passed
Copy link

🎉 This PR is included in version 10.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants